add Encode method for memory sensitive cases #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: phuslu <phus.lu@gmail.com>
danmcgee-soda
pushed a commit
to sodahealth/xid
that referenced
this pull request
Jun 8, 2022
Now that an `Encode()` method was added in rs#56, it is less necessary to resort to unsafe methods in `String()`. This also appears to have minimal benefit, as seen by these before (using unsafe) and after (without unsafe) benchmarks: Before (using unsafe): % go test -benchmem -bench . goos: darwin goarch: arm64 pkg: github.com/rs/xid BenchmarkNew-8 21845306 52.34 ns/op 0 B/op 0 allocs/op BenchmarkNewString-8 22674129 51.18 ns/op 0 B/op 0 allocs/op BenchmarkFromString-8 286217863 4.233 ns/op 0 B/op 0 allocs/op PASS ok github.com/rs/xid 4.142s After (without unsafe): % go test -benchmem -bench . goos: darwin goarch: arm64 pkg: github.com/rs/xid BenchmarkNew-8 21423278 53.01 ns/op 0 B/op 0 allocs/op BenchmarkNewString-8 21977233 53.67 ns/op 0 B/op 0 allocs/op BenchmarkFromString-8 289641164 4.162 ns/op 0 B/op 0 allocs/op PASS ok github.com/rs/xid 4.181s
rs
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Remove superfluous bitmasking in `encode` We only need to mask with `&0x1F` once per generated character, rather than twice as we did in many cases. As long as the `&0x1F` operation is last, we will always throw away the top three bits as expected. * Remove use of `unsafe` in `String()` method Now that an `Encode()` method was added in #56, it is less necessary to resort to unsafe methods in `String()`. This also appears to have minimal benefit, as seen by these before (using unsafe) and after (without unsafe) benchmarks: Before (using unsafe): % go test -benchmem -bench . goos: darwin goarch: arm64 pkg: github.com/rs/xid BenchmarkNew-8 21845306 52.34 ns/op 0 B/op 0 allocs/op BenchmarkNewString-8 22674129 51.18 ns/op 0 B/op 0 allocs/op BenchmarkFromString-8 286217863 4.233 ns/op 0 B/op 0 allocs/op PASS ok github.com/rs/xid 4.142s After (without unsafe): % go test -benchmem -bench . goos: darwin goarch: arm64 pkg: github.com/rs/xid BenchmarkNew-8 21423278 53.01 ns/op 0 B/op 0 allocs/op BenchmarkNewString-8 21977233 53.67 ns/op 0 B/op 0 allocs/op BenchmarkFromString-8 289641164 4.162 ns/op 0 B/op 0 allocs/op PASS ok github.com/rs/xid 4.181s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xid is wonderful for tracing, it would be nice to add a
Encodemethod, enabling us to write zero allocation servers. Thanks.Signed-off-by: phuslu phus.lu@gmail.com